Yesterday we made all the suggested changes. A x-mixed-replace type check took a lot of time as it was a bit confusing. Tests now produced different results than what they used to earlier, an accomplishment :P Yay (Though 2 new tests have started failing rather than passing)
We already have around 57 comments on our PR.
We are waiting for a review, probably we'd be getting more suggestions yet again. We plan to complete the algorithm by today.
You must be logged in to add a comment.