Displaying activities 1 - 25 of 62 in total
September 30, 2017
Team Code Bears (diaspora*)  — at September 30, 2017 13:24 UTC
Today we finished working on the PR comments. All the tests passed!!! And
we pushed our last peace of code for the summer.
We also presented the project at SoundCloud demos and had a sad farewell
from all the nice people there.
Thanks for this amazing summer!!!
September 28, 2017
Team Code Bears (diaspora*)  — at September 28, 2017 21:00 UTC
We fixed today the comments on the PR. Still got one more: https://github.com/diaspora/diaspora/pull/7624/files/82b51fe2be2e831a65901525d46b479326fb5e7b#diff-e05cbf49e32c6e7bf561b6624025f416
September 26, 2017
Team Code Bears (diaspora*)  — at September 26, 2017 15:44 UTC
We and our last retro today and it was very nice. lots of good points raised and some improvement suggestions for next SoC. We kept recapping what we have learned this summer and talked with diaspora ppl to understand where our PR stands.
September 22, 2017
September 20, 2017
Team Code Bears (diaspora*)  — at September 20, 2017 14:14 UTC
Today we worked mainly on fixing the comments that we received on the questions that we asked yesterday on the issue page on github. Some minor fixes we were able to solve quickly. Then it took us some time to find a db query to retrieve the month and the day of a birthday that works both with mysql and postgres. Finally we managed to solve this using the extract method.
After that we ran the rspec and realized that some tests were failing that seem to be somehow related to our changes. We are still in the process of figuring out what the exact relation is an how we can solve it.
September 19, 2017
Team Code Bears (diaspora*)  — at September 19, 2017 16:44 UTC
Today we finished our tasks on the issue. We checked in the rails consul and server that the birthday notification works. We created a notification and saw that it calls the right methods in order to send a notification and an email. Then, at the email notifications preferences, we switched off the check box for the birthday notification and saw that a notification is sent but an email isn't. We also checked that this functionality is tested in the code. Then we asked on the issue page some questions we had and we are waiting for answers. Tomorrow we want to run all the tests . Other than working on the issue, we started to work in the end presentation for the Rails Girls Berlin end event.
September 18, 2017
Team Code Bears (diaspora*)  — at September 18, 2017 15:37 UTC
Today we made some amazing progress on our issue. After struggling a lot with the different methods in workers, mailers and so on, we figured out why our test was not passing. We actually solved a list of 6 steps that we had written to ourselves last week (and we thought it would take us at least 3 days to finish :) ):
- draw a birthday notification life cycle
- figure out where to add an argument in the send_notification method
- finish the specs
- add the view template for the email
- add possibility to choose if user wants to receive an email notification
- add a date to the text in the translation file (including a new method to call the date)
September 16, 2017
Team Code Bears (diaspora*)  — at September 16, 2017 11:52 UTC
We started the day just where we left yesterday: tracking the path of one Bday notification. Apparently 9 files are involved in this on the server side. We still did not find our missing/wrong code, but some questions came up. Next thing to do would be to compare the Bday notification path to another notification path and see if there is a difference.
Other than working on diaspora we fixed comment on our blog-post.
September 14, 2017
Team Code Bears (diaspora*)  — at September 14, 2017 20:38 UTC
Today we decided to leave the worker tests behind for now and started working on the mailers. We successfully did a TDD cycle for the first part of this. Then we got a bit stuck on understanding one method, because the test keep telling us that needed to give one more argument. So we followed the path of the mailer, and found one method that needs one more argument. Now we need to find out how to pass this argument, since we are not calling the method directly. But it seems that we did some progress on the issue today. We also made a plan on all the steps that are missing to solve the issue.
September 13, 2017
Team Code Bears (diaspora*)  — at September 13, 2017 20:15 UTC
Today we tried to understand in detail what the destroy method on a contact does. Our data model is sometimes quite confusing, since there are Users, and each user has a profile and a person. The person is the user viewed from the outside. So we had some confusion about what is a contact and what receiving and sharing means for each contact. We figured it out in the end more or less, but we will contact the community to make sure that we got it right. Next step then is the mailers.
Team Code Bears (diaspora*)  — at September 13, 2017 08:05 UTC
We finished writing the worker tests. We had to set a test where the user don't have a contact, and spent quite some time realizing how to do that. But, we managed to understand the test helper and how to use it best in order to set up the tests. We still need to make sure we are using the right method in the worker, but other than that this part is done and we can move on to the mailer.
September 11, 2017
September 08, 2017
Team Code Bears (diaspora*)  — at September 8, 2017 17:33 UTC
Today we finished writing the worker and started writing the tests for it.
We have some more tests to write and struggling with setting up the contact object for the test. The last test fails because of that.
After that we plan to refactor the tests file.
Important concepts we learned this week: Mocks, Stubs, Sidekiq, Timecop (freeze), pgadmin
Repeated: ActiveRecords queries(where), Rspec contexts
September 07, 2017
Team Code Bears (diaspora*)  — at September 7, 2017 15:50 UTC
We started working on the worker and it's tests
First we defined the expected behaviors from our worker.
Then we started writing the
performmethod at the worker.
At the coaching session we made the query to the database more efficient that it was.
We still have an error - we are probably calling the notify method in a wrong way so we need to figure that out before we continue to specify the tests.
Good documentation for our current issue sidekiq wiki and a related rails cast video.
We were also handling some problems running the app on one of the computers. After a-lot of stuck overflow trail and error, we simply reset this computer to the first commit, pulled again and it worked
September 06, 2017
Team Code Bears (diaspora*)  — at September 6, 2017 14:14 UTC
Today we went deeper into some new rspec concepts. The notifications specs are written a with new syntax we did not met in the specs we worked on so far. We had a great white board session with our coach about mocks in rspec. This documentation was helpful.
Afterwards we played with the spec we wrote in
contacts_birthday_spec.rbin order to practice what we learned. We made the test fail some times and then made it green again.
Now we feel much more ready to write tests for the rest of our feature.
September 05, 2017
Team Code Bears (diaspora*)  — at September 5, 2017 15:36 UTC
Today we wrote the test for the notification we created yesterday. It was challenging because the rspec syntax was a bit different that we are use to. Through working on the tests we realized that some things in our actual implementation were wrong and we fixed them. Now we have a notification and an rspec for it. Next steps are (while keeping tdd in mind):
1. Create a test for a worker and a worker.
2. Create a test for a mailer and a mailer.
3. Enable the user to turn off birthday notifications emails.
September 04, 2017
Team Code Bears (diaspora*)  — at September 4, 2017 15:14 UTC
Neta is back, yay! So nice to be working as a team again :)
Today we solved the first step in our plan for the current issue: created a new notification type in
app/models/notificationsand made it work through the console.
For tomorrow we will write the tests for this new notification type and then create a worker that calls the notify method with the users contacts as recipients when a user has their birthday.
September 01, 2017
Team Code Bears (diaspora*)  — at September 1, 2017 09:58 UTC
Yesterday I worked mainly on understanding how the exisiting notifications work. I played with the Rails console to create different kinds of notifications. For this step the files that are most relevant are:
app/services/notification_service.rb--> there the type.notify method is used, which is why it is important to have a self.notify method in the class of each notification type in this directory:
app/models/notification.rb--> here the recipient, actor and target are passed which is relevant to us when creating the new notification type
With one of the coaches I discussed the need of separating different parts of the software in software design. Still need to read more about this, as I´m not sure if I understood everything he said :)
August 30, 2017
Team Code Bears (diaspora*)  — at August 30, 2017 20:11 UTC
Besides continuing with the first steps to solve the next issue, I learned mainly about security and encryption today. Had a nice long session with a coach about this and she pointed me to this amazing website, which I can highly recommend: https://securityinabox.org
Also I had to fix some small things on my laptop which I´ve had issues with since I had to reinstall my linux some weeks back.
August 29, 2017
Team Code Bears (diaspora*)  — at August 29, 2017 19:00 UTC
After two coaching sessions today, this is the plan how to approach the issue from now on:
1) understand how the existing notifications work (important files and directories:
2) create new notification type which shows the birthday of a user to their contacts (here still without workers, just displaying the birthday in the Notifications)
3) get all of this working in the console
4) create worker that iterates over all profiles on a pod, checks if today is the birthday and then for each contact of the user calls the method in the newly created birthday notification type (see step 2) (important files and directories:
5) create NotificationMailer according to the other Notification types (important files and directories:
From step 4 onwards it would be nice to use TDD as the steps are quite clear. For steps 1-3 it´s better to try stuff and play around until it works.
August 28, 2017
Team Code Bears (diaspora*)  — at August 28, 2017 14:44 UTC
Neta is off this week, so I, Rete, started to read more into topics that are necessary for our next issue. These include:
Also continued looking at the -possibly- relevant sections of our code and started thinking about how to approach this issue keeping TDD in mind...
August 25, 2017
Team Code Bears (diaspora*)  — at August 25, 2017 15:47 UTC
Today again we needed to look at some more comments we got from the reviewers. We really really hope that our corrections are ok now. We had a session with one of our coaches on questions we had about the requested changes and that was very helpful. Then we started discussing our next issue and how to approach it. Realized that we need to learn about workers and sidekiq next week. Finally we had a look at the relevant code before going into the weekend.
August 24, 2017
Team Code Bears (diaspora*)  — at August 24, 2017 14:37 UTC
Today our front-end code got approved from the reviewers but we got some more comments on the back-end code of our PR. We had to remove one method to make the code shorter which also involved some more changes in other parts of the code, particularly the tests. We also wrote one more test that we were asked to write. In the end it took us some time to make all the tests green. Now we´re hoping that there are no more changes on that side. Lets see...
Regarding our next issue, we are thinking of this one. We decided to work on the same issue rather than picking two separate ones as we had thought before.